Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract cli-config-apple for linking #2536

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

thymikee
Copy link
Member

Summary:

Extract a new cli-config-apple package for linking purposes, so that we can import dependencyConfig and projectConfig without all the command code.

Test Plan:

Existing tests, no public API should be affected

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the docs Documentation change label Oct 30, 2024
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small nit comment. I see that config.test.ts is failing but that's because we didn't update our snapshots after new major release of React Native, rest looks good! 🙌

packages/cli-config-apple/package.json Outdated Show resolved Hide resolved
@thymikee thymikee merged commit 9a25c5f into main Oct 30, 2024
4 of 10 checks passed
@thymikee thymikee deleted the refactor/cli-config-apple branch October 30, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants