Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xcworkspaces parsing should handle many xcprojects #2522

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: xcworkspaces parsing should handle many xcprojects #2522

merged 1 commit into from
Oct 8, 2024

Conversation

blakef
Copy link
Contributor

@blakef blakef commented Oct 8, 2024

Summary:

We've been notified of a case where a user legitimately has more files in listed in their workspace than the project and pods. This would crash when running: npm @react-native-community/cli ios

Fixes: facebook/react-native#46881

Test Plan:

./node_modules/.bin/jest --skipFilter packages/cli-platform-apple/src/tools/__tests__/getInfo.test.ts

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@blakef
fix: xcworkspaces parsing should handle many xcprojects
12877a5 
We've been notified of a case where a user legitimately has more files
in listed in their workspace than the project and pods. This would crash
when running: npm @react-native-community/cli ios

Fixes: facebook/react-native#46881
@github-actions github-actions bot added the bugfix label Oct 8, 2024
@blakef blakef mentioned this pull request Oct 8, 2024
Closed
szymonrybczak
szymonrybczak approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix!

@blakef blakef merged commit aa981e8 into main Oct 8, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi cipolleschi is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container folder is not a project file 0.75.4
2 participants
@blakef @szymonrybczak