Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-tools): declare dependency on prompts #2518

Merged

Conversation

tido64
Copy link
Contributor

@tido64 tido64 commented Oct 2, 2024

Summary:

prompts is used in cli-tools, but never declared as a dependency, causing commands to fail in pnpm setups:

Error: Cannot find module 'prompts'
Require stack:
- /~/node_modules/.store/@react-native-community-cli-tools-npm-14.0.1-fb5b1d1033/package/build/prompt.js
- /~/node_modules/.store/@react-native-community-cli-tools-npm-14.0.1-fb5b1d1033/package/build/index.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/errors/InvalidNameError.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/validate.js
- /~/node_modules/.store/@react-native-community-cli-npm-14.0.1-d30aee3125/package/build/commands/init/init.js

Test Plan:

n/a

@tido64
Copy link
Contributor Author

tido64 commented Oct 2, 2024

This needs to be cherry-picked to 14.x.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee merged commit 9da12a4 into react-native-community:main Oct 2, 2024
8 of 10 checks passed
@tido64 tido64 deleted the tido/cli-tools/missing-prompts branch October 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants