fix: issue calling init from 0.75.0-rc.1 release #2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakef
commented
Jun 25, 2024
When users call the cli through react-native (a deprecated path), it hard-codes the platform name to 'react-native'. This is an error, and doing this bypasses all template selection logic. This excludes setting the platform name to 'react-native', which is assumed.
blakef
force-pushed
the
fix-react-native-75-rc1-patch
branch
from
9b33645
to
4f95208
Compare
cortinico
approved these changes
Jun 26, 2024
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When users call the cli through react-native (a deprecated path), it hard-codes the platform name to 'react-native'. This is an error, and doing this bypasses all template selection logic.
This excludes setting the platform name to 'react-native', which is assumed.
Test Plan:
Replicates these changes to the npx cache
~/.npx/_cache/.../index.jsto confirm this fixes the issue holding up the release. Added some logging to show:run()method is called withreact-native, which we should ignore.process.argvused to callChecklist