Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use preferred device in default mode #2363

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

In #2162 I added preferred device feature - it saves device id to cache, and then when running run-ios command it'll push preferred device to the beginning.

For some strange reason, we only enabled this for --interactive or --list-devices mode. In this Pull Request preferred device is also in default mode.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run run-ios --interactive pick a simulator
  3. Open bunch other simulators
  4. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios
  1. It should pick one that was selected in the interactive prompt.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak

This comment was marked as outdated.

@szymonrybczak szymonrybczak force-pushed the fix/behaviours-with-preffered-device branch from 8a0e913 to c4017e1 Compare June 4, 2024 17:35
@thymikee
Copy link
Member

thymikee commented Jun 5, 2024

Is there a way we could fit setting and getting the preferred device from cache inside a single fn like promptForDeviceSelection?

Copy link

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Sep 23, 2024
@thymikee thymikee merged commit 0c8439f into main Sep 23, 2024
10 checks passed
@thymikee thymikee deleted the fix/behaviours-with-preffered-device branch September 23, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants