Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Quotation and Path Handling in CLI Tools #2238

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Improve Quotation and Path Handling in CLI Tools #2238

merged 1 commit into from
Jan 3, 2024

Conversation

snowleopard17
Copy link
Contributor

This pull request addresses compatibility issues with the 'make run-android' command in various shell environments. The changes ensure consistent behavior across different shells by improving path handling and quoting. Specifically, the modifications in 'launchPackager.command' and 'startServerInNewWindow.ts' include enclosing paths with spaces in double quotes and refining the quoting of variables.

@szymonrybczak
Copy link
Collaborator

Thank you! 🙏 In initial implementation quotes were there, so dunno why we removed it 😅

@szymonrybczak
Copy link
Collaborator

hey @snowleopard17, can I ask why did you close the PR? 🧐 was it missclick?

@snowleopard17
Copy link
Contributor Author

@szymonrybczak Hey sorry first PR, so I thought after getting approved we suppose to close it.

@thymikee thymikee merged commit 0e8cf75 into react-native-community:main Jan 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants