-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow overriding commands from react-native.config.js
#2229
Conversation
react-native.config.js
1a208cc
to
3ba0804
Compare
react-native.config.js
react-native.config.js
Any idea how we can make this work for |
I don't quite understand what do you mean here 🤔 I created new project, added Re.Pack with CleanShot.2023-12-22.at.16.38.03.mp4 |
@tom-sherman bump :) ⬆️ |
Hmm, could it be the react native version I'm running? I tried applying this as a patch to my RN 0.72.5 app and it continued to use metro. It's probably just my setup in any case, so pls don't block the PR on my experience! |
I don't think so. Did you follow CONTRIBUTING.md? |
I applied the change manually with |
Let's add a test for this behavior in |
Done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's document this
Summary:
Closes #2227, from now commands added inside
react-native.config.js
will override existing ones.Test Plan:
react-native.config.js
file with following content:Checklist