Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix loading Metro config from alternative config path #2043

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Aug 2, 2023

Summary

Resolves #2042. Config validation within loadMetroConfig was not passing options.config to Metro's resolveConfig function — where this is done later for loadConfig.

Test Plan

No --config arg (Unchanged)

image

✅ Implicitly loads ./metro.config.js

With --config specified

image

✅ Loads metro.config.js file from alternative file path

With --config specified, file does not exist

image

✅ Throws underlying error from Metro

(Note: This error message could be improved in Metro's source — to keep CLI lean I'm not wrapping this with anything now as the error is just about clear enough, cc @robhogan)

@huntie huntie force-pushed the load-metro-config-fix branch from 0c95dec to 3878e97 Compare August 2, 2023 15:15
@huntie huntie force-pushed the load-metro-config-fix branch from 3878e97 to 26c8f64 Compare August 2, 2023 15:20
@huntie huntie marked this pull request as ready for review August 2, 2023 15:24
@huntie huntie requested review from adamTrz and thymikee as code owners August 2, 2023 15:24
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙌

@szymonrybczak
Copy link
Collaborator

We need to release this change and backport to 0.72. cc. @thymikee

@thymikee
Copy link
Member

thymikee commented Aug 7, 2023

@huntie mind creating a second PR targeting the 12.x branch please? 🙏🏼

@huntie huntie deleted the load-metro-config-fix branch August 8, 2023 10:08
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

WARNING: This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.

- react-native-community/cli#2021
- react-native-community/cli#2024
- react-native-community/cli#2043
- react-native-community/cli#2047

### To do

- [ ] Bump CLI dependencies when next alpha published.
- [ ] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 964902e7b1bdd9a5ca16768d6b85ef6d9018b44c
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Pull Request resolved: facebook#38944

Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

WARNING: This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.

- react-native-community/cli#2021
- react-native-community/cli#2024
- react-native-community/cli#2043
- react-native-community/cli#2047

### To do

- [ ] Bump CLI dependencies when next alpha published.
- [ ] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 300f1b2553512150462cda328e87232ca1d93700
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 2586f084dd5e4f82b78709655727088842335d93
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: cd5b2e2f39e6561f6bef677faa44693c0d2fe246
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: ba5f4fdebe973f75f73cc3a38d5be8060849ff2b
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 757d915227040233d2d8375be4054d00926ca529
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: c11ccf7eff6dbc1a8ff384e8d3564cacbe94af8d
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: f889cd0b14af3a0fc3c60c8baf854afcbdb00d3b
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: ae6c00944fe8bcfe6524dddfed8e18fc96e29945
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: b14732c8635aa2669103e93bfe646f80f64f27c4
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: 6e68164929646fb5eb92ae8051aea0115a097163
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 06247e60bc1ff77aa9bed48cb1e18293f5a7c419
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: 30d9223b3941a1082a11b3e311e26e498445a9cb
huntie added a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 77c30bc92df3cc4d84a097e78519e097157293a4
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: f0845f4a087747e78fcf0af87ffa464041449b1e
huntie pushed a commit to huntie/react-native that referenced this pull request Aug 11, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: https://internalfb.com/D48066179

fbshipit-source-id: a4ec9e84fcf762a50d1a7524f42c41e484076077
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047
- Upgrade to RN CLI `12.0.0-alpha.9`, including Metro bump to `0.78.0`.

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: b290f2834691a680ba51ea19981f4e7b707b5a23
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: c09b32f0a3590570680f46fbe6d7368ce37bd8e6
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: c09abbbbdc69faeccd6d1091a042e1502fb8dd97
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 5f1d3d749b451dc3bdbea58d3f8c4a79d6aaba60
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: ea46b4a791f3a2c215c08bba33eee3a437aba9d7
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: c47d14af132089796724f0375f3795488a90f88d
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 2fe6d8301990982e589f54c7c75fb7dec008c2f6
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: c5c9fa40729de2c84517d3e1c3b4fdae71ae7bab
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: bb90bf5776facc8b39050e1555e0b7009d046d99
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 1fa5f775972165541713a0a1c9e7702dba14b485
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 32aee8890db0c65791fe640c8993d06fc200f4ff
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 26aaee808bf815ec2f48b936d4c9883bcc6026ef
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 986264a7cc23f3e6adee05781946d57d0c579081
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: c415984bbac10cc4b4e0c6031d80eb0f2db95eb0
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: d08f0f8c3bd10f4de96b545b8ded7a4b22e6ae27
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: d867f1295f5c36ff96c4a595dd5833c0ee5769f5
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 457644ba45c12be8fc22587b746e924dd8bf234a
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: cf74bc09f5a3afc272979e2cdcbe6aa695cb80fd
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: f83828efe2b6bb8da1bb2e11c523f71da601e46f
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 4c339af9715c80fa45ed4348564461c5703530c2
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 122353191146a84284eb3d821cdc2e327b57e902
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: ab3de8428423bfe3b8c63055662a5ba91dcf2236
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 091047372137e4dfaead6221544d47872da5a878
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 36c63f21dded683ab5b6f1f8205b8e0529e83d9c
huntie added a commit to huntie/react-native that referenced this pull request Aug 14, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 101b7c9e529105a89d4ed68616432e3899c6c817
huntie added a commit to huntie/react-native that referenced this pull request Aug 15, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 0fea3cba2fb4f7300c2ddde5b13d4e4a4ad2733b
huntie added a commit to huntie/react-native that referenced this pull request Aug 15, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 4d8c3d9cb98a300587b98c3d81d07f544ffa314e
huntie added a commit to huntie/react-native that referenced this pull request Aug 15, 2023
Summary:
Pull Request resolved: facebook#38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: 393a6ebb06be94fb331908a47c8d409f64e63f77
huntie added a commit to huntie/react-native that referenced this pull request Aug 15, 2023
Summary:
Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.

- react-native-community/cli#2043
- react-native-community/cli#2021
- react-native-community/cli#2024

Changelog: [Internal]

Differential Revision: D48311214

fbshipit-source-id: 3f1b607cd756c8a20c41cdb7a49ba79dfa173821
facebook-github-bot pushed a commit to facebook/react-native that referenced this pull request Aug 15, 2023
Summary:
Pull Request resolved: #38944

- Update `cli-commands` package to reflect latest source `react-native-community/cli-plugin-metro` changes.
	- react-native-community/cli#2021
	- react-native-community/cli#2024
	- react-native-community/cli#2043
	- react-native-community/cli#2047

### To do

WARNING: ~~This PR is non-functional until the next CLI alpha is published and bumped in `package.json` — since it depends on corresponding new APIs in `react-native-community/cli-tools` (react-native-community/cli#2021). This package (and the upcoming work which integrates it) has been tested against locally linked copies of latest CLI.~~

- [x] Bump CLI dependencies when next alpha published.
- [x] Ensure Metro bump from `0.77.0` to `0.78.0` is consistently applied with this.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D48066179

fbshipit-source-id: b3dc8891cf33e537788f942dcaddff4d2f11a31f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-native bundle command fails to find metro.config.js
3 participants