Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace glob with fast-glob #2016

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Jul 12, 2023

Summary:

Replaced glob package with fast-glob, because:

  • fast-glob is a lot faster than glob,
  • fast-glob is few times lighter than glob.

TODO:

  • Make sure that these changes don't broke running CLI on Windows.

Test Plan:

CI Green ✅

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the infra Internal work not facing public APIs label Jul 12, 2023
@szymonrybczak
Copy link
Collaborator Author

I changed a lot of tests because when fs.__setMockFilesystem({}); wasn't specifed in beforeAll function, but in every test suite - the tests were failing. It's very strange, but it is working correctly when mocking in beforeAll.

@szymonrybczak szymonrybczak force-pushed the chore/replace-glob-with-fast-glob branch from 1dc8be4 to 5021b4a Compare July 12, 2023 10:53
@szymonrybczak szymonrybczak force-pushed the chore/replace-glob-with-fast-glob branch from 5021b4a to 04d8bf9 Compare July 12, 2023 10:53
@thymikee
Copy link
Member

Do you have some measurements for speed improvement?

@szymonrybczak
Copy link
Collaborator Author

szymonrybczak commented Jul 12, 2023

Do you have some measurements for speed improvement?

Before these changes running getAndroidProject took 1.462 second right now it's 0.819 second 🏎️

@szymonrybczak szymonrybczak force-pushed the chore/replace-glob-with-fast-glob branch from 860d818 to ea46e9f Compare July 13, 2023 08:36
@thymikee
Copy link
Member

thymikee commented Aug 9, 2023

glob added a few perf improvements over the last few versions. Maybe we should try upgrading it to latest first and later on migrate to fast-glob for package size optimizations, if we're able to resolve Windows issues

@thymikee
Copy link
Member

ping, can we get back to this? :)

Copy link

There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days.

@github-actions github-actions bot added the stale label Dec 20, 2023
@github-actions github-actions bot closed this Dec 27, 2023
@liamjones liamjones mentioned this pull request Jan 29, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Internal work not facing public APIs stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants