feat: Add alternative base config check to loadMetroConfig (11.x) #1990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #1987.
Adds improved check to detect if
@react-native/metro-config
(containing the base Metro config for all non-Expo React Native apps — and includingrnx-kit
) has been loaded for a given project. Paired with change:Since we cannot expect all users to bump
@react-native/metro-config
in their project between0.72.0
→0.72.1
, the previous check remains alongside this. If one of these detection methods works, no warning/fallback loading is performed.Targets the
11.x
branch (React Native 0.72).📦 Please publish!: We'd like to get this convenience fix to users for React Native 0.72.1.
Test Plan
Remove
@react-native/metro-config
import from config file (existing check)✅ Logs warning and falls back to legacy defaults
Load
@react-native/metro-config
defaults in separate file (new check needed)yarn link @react-native/metro-config
✅ No warning logged, proceeds, builds
(Ignore unrelated newer config option warning)