-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing argument to xcodebuild shell (destination) #1934
fix: add missing argument to xcodebuild shell (destination) #1934
Conversation
Hi @MichelBahl thanks for the PR! 💪 Looks like prettier check is failing? 🤔 Mind resolving that? |
629fe30
to
93cef87
Compare
Removed changes in yarn.lock |
I'd like to test this but have no clue how to install this fork in my project since it is bundled into react-native.... |
Here's the guide :) Basically you have to pull the fork (you can use GH CLI to do it or do it manually with git cmd ) and link it. |
@adamTrz I followed that guide but I still get EDIT: Oh my bad I was on the wrong branch. Trying again 😓 |
Now I'm getting this:
But I linked them correctly and I can also see the link in the links folder. |
Looks like I needed to go into the linked directory and run |
IT WORKED! 🎉 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thank you for contribution! 🎉
{ | ||
name: '--destination <string>', | ||
description: 'Explicitly extend distination e.g. "arch=x86_64"', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this flag to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of react-native and the cli is this option available from? Doesn't seem to work in 0.70.14 with cli version 9.2.1. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @domthomhive, it's available since 0.72 (CLI version: 11.x).
- destination is used for to specify the arch for iOS build - this is needed for modules which require arch x84_64
93cef87
to
ed5e9cf
Compare
- destination is used for to specify the arch for iOS build - this is needed for modules which require arch x84_64
It's throwing |
Hey @medjamiaanes, are you sure that you correctly linked packages? (Please follow steps described here) |
How can I use this solution in version 0.68 of RN? (since the compatible cli version is 6.0.0 for this version) |
hey @MarcosSarges, React Native 0.68 is not supported anymore, so you should upgrade to supported version. Here's a table containing which versions are supported. If you're not able to upgrade your RN version right away you can try using |
Summary:
With the destination build parameter it can be specified what destination (arch x86_64) gonna be used to build iOS
In case you are using an apple silicon Mac to build your app and you are using Pod dependencies which were not made for apple silicon it were not possible to change the arch for these dependencies from cli.
Error:
could not find module 'Adyen' for target 'arm64-apple-ios-simulator'; found: x86_64-apple-ios-simulator, at:
xcode would prompt to Build for Rosetta and add en config file
And create a settings file (which has no effect for cli build):
Test Plan:
npx react-native run-ios --simulator="iPhone 14 Pro" --destination arch=x86_64