Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show help when no arguments are provided #160

Merged
merged 3 commits into from
Feb 11, 2019
Merged

feat: show help when no arguments are provided #160

merged 3 commits into from
Feb 11, 2019

Conversation

lucasbento
Copy link
Member

Summary:

This PR adds the default behaviour of calling the CLI without any args to be the --help command.

Fixes #158.

Test Plan:

Run the following:

node path/to/the/react-native-cli/packages/cli/build/index.js
node path/to/the/react-native-cli/packages/global-cli/index.js

thymikee
thymikee requested changes Feb 11, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

packages/cli/src/cliEntry.js Outdated Show resolved Hide resolved
packages/cli/src/cliEntry.js Outdated Show resolved Hide resolved
@thymikee
Copy link
Member

thymikee commented Feb 11, 2019 •
edited
Loading

I made some visual adjustments locally. Also rebased to latest master to get updated logger.

screenshot 2019-02-11 at 12 16 13

@Esemesek Esemesek merged commit fb62f9b into react-native-community:master Feb 11, 2019
@lucasbento lucasbento deleted the feature/show-help branch February 11, 2019 11:46
@lucasbento
Copy link
Member Author

Cool, thanks @thymikee & @Esemesek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@Esemesek Esemesek Esemesek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasbento @thymikee @Esemesek