feat: add support for custom placeholder template #1556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numandev1
requested review from
grabbou,
thymikee and
Esemesek
as code owners
|
@nomi9995 seems that tests are failing, do you mind taking a look? |
numandev1
force-pushed
the
feat/custom-placeholders-template
branch
from
8a3075f
to
6a319b2
Compare
|
@gabrieldonadel this is an architectural change so we have to update test cases if it is functionality-wise okay then i will also write test cases. |
|
There hasn't been any activity on this pull request in the past 3 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
#1470
we need to add the custom placeholder flags while init. so i added this custom placeholder support in cli
Test Plan:
you can download this template and test by this command
https://github.com/nomi9995/react-native-template-placeholder