fix: ignore non-nativetargets during ios linking #123
Conversation
|
+1 really good job imho |
|
On second glance, are we sure there are not some cases where there is silent failing that needs to be handled (I think definitely yes and they need to be documented in this pr thread.) |
There was a problem hiding this comment.
Thank you for submitting this PR! It's great that you have provided a reproduction (cloned locally and tested).
Please help me understand under what circumstances such target can be invalid and how one could create it manually.
It would be also great to have a test case for that. It would require modifying fixtures tho.
| const key = target.value; | ||
| // If not a valid target, skip. | ||
| if (!project.pbxNativeTargetSection()[key]) return undefined; | ||
| const configurationListId = project.pbxNativeTargetSection()[key] |
There was a problem hiding this comment.
While we are doing this, let's make it: nativeTargetSection[key] since we already have native target section obtained on line 17.
| .map(target => { | ||
| const key = target.value; | ||
| // If not a valid target, skip. | ||
| if (!project.pbxNativeTargetSection()[key]) return undefined; |
There was a problem hiding this comment.
Let's flip filter and map order, e.g:
targets.filter(target => nativeTargetSection[target.value] !== undefined).map(...)There was a problem hiding this comment.
It would be also great to elaborate a bit more on the comment itself. For example, I would say: "Filter out targets that are ....". I am trying to understand what exactly is an invalid target (if it's in targets section and not in the native targets section - what does it mean).
There was a problem hiding this comment.
I run into the problem whenever I have an aggregate target alongside the default ones created by the cli. From the looks of it, we only need to modify native targets when linking, so anything not in the Native Target section should be ignored.
There was a problem hiding this comment.
Oh, now I remember! Due to limitations of Xcode library, I had to enumerate native targets by getting an array of project targets first. But yeah, I wrongly assumed that all targets will be in that section, which is not the case.
Makes use of the single variable nativeTargetSection and puts filter before map when filtering out non-native targets.
|
@grabbou |
fixes issue #57