Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for network connected devices on Xcode #87

Closed
pvinis opened this issue Jan 14, 2019 · 8 comments
Closed

Support for network connected devices on Xcode #87

pvinis opened this issue Jan 14, 2019 · 8 comments

Comments

@pvinis
Copy link
Member

pvinis commented Jan 14, 2019

Xcode can connect and run apps on devices that are connected with wifi. It would be very useful to be able to run react-native run-ios --device and the app runs on a device that's connected with wifi, and not necessarily with a cable to Xcode.

I can try to make this happen. Is that alright? Would this be accepted?

@grabbou
Copy link
Member

grabbou commented Jan 16, 2019

Yeah, sure, that sounds like a good option! Please feel free to do it. I think we already support '--device' flag, you should be able to use it, right?

@grabbou grabbou modified the milestone: Better UX Jan 16, 2019
@pvinis
Copy link
Member Author

pvinis commented Jan 16, 2019

yes, basically I want to expand that so it supports network devices too. cool.

@grabbou
Copy link
Member

grabbou commented Jan 16, 2019

Let me know if you need any help - fingers crossed!

@pvinis
Copy link
Member Author

pvinis commented Jan 17, 2019

Alright, so two things:

@SukritGupta17
Copy link

Alright, so two things:

  • This repo is not yet integrated with the react-native repo right?
  • I actually tried to run-ios --device using this repo for the local-cli, and it did find my network phone, but then ios-deploy doesn't support it. ios-control/ios-deploy#370 and ios-control/ios-deploy#320

Hey, are you working on integrating this feature?

@pvinis
Copy link
Member Author

pvinis commented Feb 27, 2019

No, I just found the issues in ios-deploy. I don't have time to do this now, I just use xcode, that supports wifi.

@thymikee
Copy link
Member

thymikee commented Mar 9, 2020

@pvinis is this still an issue? I'll close for now, since it's an upstream bug

@thymikee thymikee closed this as completed Mar 9, 2020
@pvinis
Copy link
Member Author

pvinis commented Mar 16, 2020

I just tried it, worked. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants