feat: update doctor to reflect Java >= 17 (#2045)

* feat: update doctor to reflect Java >= 17 * test: update tests
react-native-community · Aug 7, 2023 · 588753c · 588753c
1 parent 0cbed3d
commit 588753c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/cli-doctor/src/tools/healthchecks/__tests__/jdk.test.ts b/packages/cli-doctor/src/tools/healthchecks/__tests__/jdk.test.ts
@@ -35,17 +35,17 @@ describe('jdk', () => {
     expect(diagnostics.needsToBeFixed).toBe(true);
   });
 
-  it('returns false if JDK version is in range (JDK [11-18] version number format)', async () => {
+  it('returns false if JDK version is in range (JDK [17-20] version number format)', async () => {
     // @ts-ignore
     environmentInfo.Languages.Java = {
-      version: '14.0.4',
+      version: '17.0.8',
     };
 
     const diagnostics = await jdk.getDiagnostics(environmentInfo);
     expect(diagnostics.needsToBeFixed).toBe(false);
   });
 
-  it('returns true if JDK version is not in range (JDK < 11 version number format)', async () => {
+  it('returns true if JDK version is not in range (JDK < 17 version number format)', async () => {
     // @ts-ignore
     environmentInfo.Languages.Java = {
       version: '1.8.0_282',
@@ -55,10 +55,10 @@ describe('jdk', () => {
     expect(diagnostics.needsToBeFixed).toBe(true);
   });
 
-  it('returns true if JDK version is not in range (JDK > 18 version number format)', async () => {
+  it('returns true if JDK version is not in range (JDK > 20 version number format)', async () => {
     // @ts-ignore
     environmentInfo.Languages.Java = {
-      version: '19.0.1',
+      version: '21.0.1',
     };
 
     const diagnostics = await jdk.getDiagnostics(environmentInfo);

diff --git a/packages/cli-doctor/src/tools/versionRanges.ts b/packages/cli-doctor/src/tools/versionRanges.ts
@@ -4,7 +4,7 @@ export default {
   YARN: '>= 1.10.x',
   NPM: '>= 4.x',
   RUBY: '>= 2.6.10',
-  JAVA: '>= 11 < 19',
+  JAVA: '>= 17 <= 20',
   // Android
   ANDROID_SDK: '>= 33.x',
   ANDROID_NDK: '>= 23.x',