Skip to content

Commit

Permalink
Remove @providesModule from all modules
Browse files Browse the repository at this point in the history
Summary:
This PR removes the need for having the `providesModule` tags in all the modules in the repository.

It configures Flow, Jest and Metro to get the module names from the filenames (`Libraries/Animated/src/nodes/AnimatedInterpolation.js` => `AnimatedInterpolation`)

* Checked the Flow configuration by running flow on the project root (no errors):

```
yarn flow
```

* Checked the Jest configuration by running the tests with a clean cache:

```
yarn jest --clearCache && yarn test
```

* Checked the Metro configuration by starting the server with a clean cache and requesting some bundles:

```
yarn run start --reset-cache
curl 'localhost:8081/IntegrationTests/AccessibilityManagerTest.bundle?platform=android'
curl 'localhost:8081/Libraries/Alert/Alert.bundle?platform=ios'
```

[INTERNAL] [FEATURE] [All] - Removed providesModule from all modules and configured tools.
Closes facebook/react-native#18995

Reviewed By: mjesun

Differential Revision: D7729509

Pulled By: rubennorte

fbshipit-source-id: 892f760a05ce1fddb088ff0cd2e97e521fb8e825
  • Loading branch information
rubennorte authored and facebook-github-bot committed Apr 25, 2018
1 parent 1394c64 commit 557692c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions core/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ const pluginPlatforms = plugins

const defaultRNConfig = {

hasteImplModulePath: require.resolve('../../jest/hasteImpl'),

getProjectCommands(): Array<CommandT> {
const commands = plugins
.commands
Expand Down

0 comments on commit 557692c

Please sign in to comment.