fix: add allowMobileScroll prop to allow for clicks to optionally pass through on mobile #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly pass through on mobile
|
Can you please invert it: "preventMobileScroll", default true. |
|
What about "allowMobileScroll"? I prefer having the default be false @STRML |
STRML
requested changes
Aug 9, 2024
STRML
approved these changes
Aug 10, 2024
STRML
changed the title
|
Thanks for the contribution. Please see the additional commit for fixups. |
|
Thanks @STRML !! Much appreciated 🙏 |
tnrich
commented
Aug 12, 2024
|
|
||
| const e = new Event('touchstart'); | ||
| // Oddly `e.defaultPrevented` is not changing here. Maybe because we're not mounted to a real doc? | ||
| let pdCalled = false; |
There was a problem hiding this comment.
nice one @STRML , thanks for adding a test! my Achilles heel!
|
@STRML it appears that I need a new release in order to be able to use the updated code. Do you think you could do that plz! Thanks!
|
|
When do we have the next release to use this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #728
@STRML let me know if this PR looks good to you. Thanks!
Add doNotPreventMobileScroll prop to allow for clicks to optionally pass through on mobile