Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added .js to all file import/exports #611

Closed

Conversation

adamhwang
Copy link
Contributor

To address ESM module resolution needs: #606

Checklist

@adamhwang
Copy link
Contributor Author

I've confirmed this is a comprehensive changeset with eslint-plugin-import. I cannot check-in the eslint rules without rebuilding the package-lock as its an older version than I have available.

If you're interested in confirming / adding, the package is eslint-plugin-import with the following additions to .eslintrc.yaml:

extends:
  - "plugin:import/warnings"
  - "plugin:import/typescript"
rules:
  "import/extensions":
    - 2
    - "always"

Copy link

@OnufryKlaczynski OnufryKlaczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fasmat
Copy link

fasmat commented Mar 15, 2022

Any chance this will be merged and released in the near future?

@markmcdowell markmcdowell force-pushed the feature/import-js-ext branch from e114f25 to 4ebc658 Compare March 15, 2022 17:08
@markmcdowell
Copy link
Collaborator

Any chance this will be merged and released in the near future?

It currently does not build, and needs a rebase to fix conflicts. I'm tempted to revert the package.json flag instead.

@adamhwang adamhwang force-pushed the feature/import-js-ext branch from 4ebc658 to 9a31f29 Compare July 12, 2022 22:27
@adamhwang adamhwang force-pushed the feature/import-js-ext branch from 9a31f29 to bf928cc Compare July 12, 2022 22:42
@adamhwang
Copy link
Contributor Author

adamhwang commented Jul 12, 2022

It currently does not build, and needs a rebase to fix conflicts. I'm tempted to revert the package.json flag instead.

I rebased and added the lint rule, but unfortunately appear to be running into this jest issue with the test: kulshekhar/ts-jest#1057

ETA: fixed the test. it's not ideal, but none of this has been 😅

@mattiaz9
Copy link

this library has been broken for months because of this. Please @markmcdowell release a new version 🙏

@LukeKoz
Copy link

LukeKoz commented Aug 1, 2022

Is there any other workaround in the meantime?

@hakunin
Copy link

hakunin commented Sep 21, 2022

Can this be resolved please?

@markmcdowell
Copy link
Collaborator

Resolved in #676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants