-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added .js to all file import/exports #611
Conversation
I've confirmed this is a comprehensive changeset with If you're interested in confirming / adding, the package is
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Any chance this will be merged and released in the near future? |
e114f25
to
4ebc658
Compare
It currently does not build, and needs a rebase to fix conflicts. I'm tempted to revert the package.json flag instead. |
4ebc658
to
9a31f29
Compare
9a31f29
to
bf928cc
Compare
I rebased and added the lint rule, but unfortunately appear to be running into this jest issue with the test: kulshekhar/ts-jest#1057 ETA: fixed the test. it's not ideal, but none of this has been 😅 |
this library has been broken for months because of this. Please @markmcdowell release a new version 🙏 |
Is there any other workaround in the meantime? |
Can this be resolved please? |
Resolved in #676 |
To address ESM module resolution needs: #606
Checklist