Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty string vs empty array inconsistency #38

Closed
ThiefMaster opened this issue Dec 4, 2019 · 3 comments
Closed

Empty string vs empty array inconsistency #38

ThiefMaster opened this issue Dec 4, 2019 · 3 comments
Assignees
@rolandjitsu
Labels
bug released

Comments

@ThiefMaster
Copy link

If acceptedFiles is an empty string, everything is accepted, but if it's an empty array, nothing is accepted. Is this intentional?
@rolandjitsu
Copy link
Collaborator

Probably not, just submit a PR and add a test case for it.

@rolandjitsu
Copy link
Collaborator

I guess this wasn't a major issue. I'll try to see if I can reproduce and fix.

@rolandjitsu rolandjitsu self-assigned this Oct 7, 2024
rolandjitsu added a commit that referenced this issue Oct 9, 2024
@rolandjitsu
fix: allow any file if accepted files is an empty array and close #38
a1a716b
@rolandjitsu rolandjitsu added the bug label Oct 9, 2024
@rolandjitsu rolandjitsu mentioned this issue Oct 9, 2024
Merged
12 tasks
rolandjitsu added a commit that referenced this issue Oct 9, 2024
@rolandjitsu
fix: allow any file if accepted files is an empty array and close #38
e9e6d33
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

🎉 This issue has been resolved in version 2.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolandjitsu rolandjitsu

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThiefMaster @rolandjitsu