This repository has been archived by the owner on Jun 18, 2018. It is now read-only.
[In progress] Fix iframe #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is still the default target.
pgib
reviewed
Jan 25, 2017
| @@ -34,25 +34,26 @@ export default class HTML5Backend { | |||
| this.endDragNativeItem = this.endDragNativeItem.bind(this); | |||
| } | |||
|
|
|||
| setup() { | |||
| if (typeof window === 'undefined') { | |||
| setup(target = window) { | |||
There was a problem hiding this comment.
@Vadorequest I see this is closed, but I'm doing somewhere where this would be really useful. I'm just wondering how you would wire things up to pass in an alternative target?
There was a problem hiding this comment.
I have some PRs open that include the ability to use a different window context. After we get done with basic maintenance things I will add this
There was a problem hiding this comment.
There was a problem hiding this comment.
@darthtrevino Oh, nice! Thanks for that. If I wanted to play around with that, how does one pass along a different context?
e.g. From:
export default DragDropContext(HTML5Backend)(IframeDragReceiver)
to ... ?
There was a problem hiding this comment.
When it finalizes, it will look something like:
render() {
<DragDropContext backend={HTML5Backend} context={{window: iframeWindowInstance}}>
// your app
</DragDrapContext>
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to pass a specific target to setup/teardown functions. "window" is still the default target.