Skip to content
This repository has been archived by the owner on Jun 18, 2018. It is now read-only.

File drop not working on the ReactDND website using Chrome #19

Closed
adityasan92 opened this issue Feb 13, 2016 · 8 comments
Closed

File drop not working on the ReactDND website using Chrome #19

adityasan92 opened this issue Feb 13, 2016 · 8 comments

Comments

@adityasan92
Copy link

Hi,

I am trying to get the file drop feature work. It seems to not be working on the http://gaearon.github.io/react-dnd/examples-dustbin-multiple-targets.html

I get the error:** Uncaught Invariant Violation: Cannot call hover while not dragging. **I am using Chrome. I am new to react and redux. Please help me thanks.
image

@gaearon
Copy link
Member

gaearon commented Feb 13, 2016

I can’t reproduce this on OS X with Chrome 48. Please post your operating system (Windows, assuming from scroll bars), Chrome version, and exact sequence of steps to reproduce the problem.

@gaearon gaearon changed the title File drop not working on the ReactDND website using Chrome ) File drop not working on the ReactDND website using Chrome Feb 13, 2016
@adityasan92
Copy link
Author

Hey gaearon,

I am using windows 10, and the Chrome Version is 48.0.2564.109 m. I was trying to use the file drop feature on the website, so I tried dropping a txt file into the Dustbin that accepts the Native_file on the website. that gave me the above error. When I use firefox it seems to be dropping but gives a warning as show below
image

Thanks for the reply. Big fan of ReactDND and Redux.

@gaearon
Copy link
Member

gaearon commented Feb 13, 2016

This should be fixed in [email protected].
Please verify.

(I have not had time to update the website yet but I will later today.)

@gaearon gaearon closed this as completed Feb 13, 2016
@adityasan92
Copy link
Author

Thanks the new version works!!

@gaearon
Copy link
Member

gaearon commented Feb 14, 2016

I’m glad! (I had to buy a BrowserStack license to debug it 😅 )

@mrcrlee
Copy link

mrcrlee commented May 10, 2016

Dan,

Thanks for your attention to this issue.

I've discovered, while using in development and through the dustbin examples hosted on github, this issue does persist on the following platform:

Windows 7 Enterprise
Firefox: 38.5.0

Screenshot attached.

dnderror

@stevengoldberg
Copy link

Hey @gaearon, I've been seeing this pop up in my error logs as well -- looks like it's happening to users on Windows 7 and Windows 10, and all on Firefox 47, when they're trying to do something with file drag-and-drop. I've got "react-dnd": "^2.1.4" and "react-dnd-html5-backend": "^2.1.2".

@razjel
Copy link

razjel commented Oct 5, 2016

I also can't figure out how to solve this problem, but I discovered that It's most probably because of this fix in HTML5Backend.js

    // On Firefox, if mousemove fires, the drag is over but browser failed to tell us.
    // This is not true for other browsers.
    if (isFirefox()) {
      window.addEventListener('mousemove', this.endDragNativeItem, true);
    }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants