-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tabIndex to be set explicitly on Handle #381
Allow tabIndex to be set explicitly on Handle #381
Conversation
Thanks @paranoidjk and @yesmeck ! When can we expect a new release? |
@paranoidjk @yesmeck could we get another release with that change in it please? |
Released [email protected] |
Thanks! |
@yesmeck I'm not seeing my changes reflected in the |
Yes, search |
I updated to 8.6.0 version, but passing tabIndex={-1} is still not setting tabindex=-1 for handles for Range.
|
@Shardendu-kantha Line 23 in 7a021d4
|
@Robin-front thank you so much. Got the solution. cheers |
Basic implementation of
tabIndex
prop on the Handle component. Both Slider.js and Range.js also implementtabIndex,
but in both cases it's simply passed through to the Handle. I've also updated the test suite with some simple checks to make suretabIndex
gets set properly on Handle from its parent. I've updated the README doc as well.The default value for
tabIndex
is preserved (it's still "0"), so this change should not break any existing uses.This is a fix for #353
cc: @paranoidjk