feat: support extra option #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@afc163 佬，有空review一下～ |
afc163
reviewed
Aug 13, 2024
afc163
reviewed
Aug 13, 2024
afc163
reviewed
Aug 13, 2024
afc163
reviewed
Aug 13, 2024
assets/index.less
Outdated
|
|
||
| &-item { | ||
| display: flex; | ||
| justify-content: space-between; |
There was a problem hiding this comment.
items={[{
label: <><span>内容</span><span>内容</span><>,
extra: 'extra',
}]}
这种情况可能会有问题。
There was a problem hiding this comment.
单独给extra，margin-left: auto了，不会存在了
There was a problem hiding this comment.
label 也得包一下。
这个，应该不能包裹，如果有用户使用子集选择器会出现问题
items={[{
label: <p>内容</p>,
extra: 'extra',
}]}
render:
<span><p>内容</p></span>
/* 失效 */
> p {
}There was a problem hiding this comment.
佬，这个麻烦再看一眼，感觉应该没啥问题了～
afc163
reviewed
Aug 13, 2024
Co-authored-by: afc163 <[email protected]>
|
给extra加了一个 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 27 27
Lines 734 736 +2
Branches 200 202 +2
=======================================
+ Hits 731 733 +2
Misses 3 3 ☔ View full report in Codecov by Sentry. |
这种情况好像渲染还是会不太对。 |
|
原来是 
|
|
哦，还有 README 里要补一下文档。 |
This was referenced Aug 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ant-design/ant-design#49127