-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix submenu focus #662
fix submenu focus #662
Conversation
Please add some test cases to cover this. |
I wanted to add some tests, but then I realized that rc-menu doesn't have an |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 99.58% 99.58%
=======================================
Files 27 27
Lines 721 722 +1
Branches 196 196
=======================================
+ Hits 718 719 +1
Misses 3 3 ☔ View full report in Codecov by Sentry. |
cc @MadCcc |
Is this issue related? |
src/SubMenu/index.tsx
Outdated
import { warnItemProp } from '../utils/warnUtil'; | ||
import InlineSubMenuList from './InlineSubMenuList'; | ||
import PopupTrigger from './PopupTrigger'; | ||
import SubMenuList from './SubMenuList'; | ||
|
||
export interface SubMenuProps | ||
extends Omit<SubMenuType, 'key' | 'children' | 'label'> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change on this file should be reverted since nothing except order changed.
Test for the first problem should be provided, you can trigger focus manually in test case to mock the scene. |
No, this PR is not relevant to the above issue |
Ok, I'll try |
Now it conflicts. |
352ea9d
to
2ff8bad
Compare
Closing this since I can no longer reproduce the first issue |
Fixes the following issues:
2023-08-09.14-51-25.mp4
2023-08-09.14-56-16.mp4
Note: I use the antd Dropdown component in the videos above