Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unmounting portal when parent is unmounted #74

Merged
merged 1 commit into from
Apr 3, 2016
Merged

Fix unmounting portal when parent is unmounted #74

merged 1 commit into from
Apr 3, 2016

Commits on Apr 3, 2016

  1. Fix unmounting portal when parent is unmounted. 

    When a portal is mounted and references a container which
unmounts before the portal, an error occurs as the
result of getContainerDOMNode will become "body" and
removeChild fails. This removes getContainerDOMNode
in favor of caching the container on the instance as
"_portalContainerNode".
    @tgriesser
    tgriesser committed Apr 3, 2016
    Configuration menu
    Copy the full SHA
    b08a5e6 View commit details
    Browse the repository at this point in the history