[fixed] New props are flushed before any new transition #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this.props.unmountOnExit && this.state.status === EXITED) { | ||
| const status = this.state.status; | ||
|
|
||
| if (this.props.unmountOnExit && status === EXITED) { |
There was a problem hiding this comment.
Do we need to return at the end of this and skip the bottom checks?
There was a problem hiding this comment.
probably safer yeah...I'm honestly not sure though
There was a problem hiding this comment.
At a glance, it looks like you could at least hit performEnter twice, maybe.
jquense
force-pushed
the
transition-props
branch
from
13d9331
to
19627bc
Compare
jquense
added a commit
that referenced
this pull request
Jan 28, 2016
[fixed] New props are flushed before any new transition
This was referenced Jul 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #40.