Drop busted getOverlayDOMNode #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jquense
approved these changes
Oct 24, 2017
|
This broke some of my code. I understand it was an undocumented method, but it certainly looks like a public method in the code (no prepended underscore). Minor version bump would have been nice here. With this method gone, what's the canonical way to get the overlay node, just a |
|
It was non-functional in the previous commit anyway. Just use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It actually doesn't even do anything on the non-legacy portal. Plus it's broken on the legacy portal half the time anyway. Since we already broke it, and we don't document it, I'm going to say this was some internal test-only thing, and it's not semver-breaking to just remove it entirely.