Mismatch between Modal.dialog and hideSiblings parameters #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! Is there any chance you could add a regression test here? |
taion
approved these changes
Aug 27, 2019
Added |
taion
approved these changes
Sep 4, 2019
jquense
approved these changes
Sep 4, 2019
|
i don't understand how to read these CI checks...where is even the logs for CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue raised here: #240
The modal component contains refs to
dialogandbackdrophttps://github.com/omniverse/react-overlays/blob/master/src/Modal.js#L309-L315not
rootandbackdropas destructured in manageAriaHidden https://github.com/omniverse/react-overlays/blob/master/src/Modal.js#L309-L315So the aria-hidden="true" attribute was getting applied to the dialog itself and breaking screen readers, accessibility features, etc.