We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ariaHidden is added to modal div, not it's container.
ariaHidden
But this line tries to remove it from container.
react-overlays/src/ModalManager.js
Line 141 in 4498bb1
The text was updated successfully, but these errors were encountered:
Yes! This is messing up screen readers.
Sorry, something went wrong.
Actually, the code above is obsolete. But there are still issues with aria-hidden="true" getting set on the dialog itself.
aria-hidden="true"
The hideSiblings param declaration hideSiblings(container, { root, backdrop }) doesn't match what is being passed in. On https://github.com/react-bootstrap/react-overlays/blob/master/src/ModalManager.js#L93 should be something like hideSiblings(container, {root: modal.dialog});
hideSiblings(container, { root, backdrop })
hideSiblings(container, {root: modal.dialog});
Actually, the code above is obsolete.
This is in the version used by the latest stable version of react-bootstrap. Would you consider releasing a patch for this on that basis?
No branches or pull requests
ariaHidden
is added to modal div, not it's container.But this line tries to remove it from container.
react-overlays/src/ModalManager.js
Line 141 in 4498bb1
The text was updated successfully, but these errors were encountered: