Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ariaHidden(false, ..) should (probably) use modalNode insted of mountNode #240

Open
ruslansavenok opened this issue Mar 27, 2018 · 3 comments

Comments

@ruslansavenok
Copy link

ariaHidden is added to modal div, not it's container.

But this line tries to remove it from container.

ariaHidden(false, data.modals[data.modals.length - 1].mountNode);

@omniverse
Copy link
Contributor

Yes! This is messing up screen readers.

@omniverse
Copy link
Contributor

omniverse commented May 24, 2019

Actually, the code above is obsolete. But there are still issues with aria-hidden="true" getting set on the dialog itself.

The hideSiblings param declaration hideSiblings(container, { root, backdrop }) doesn't match what is being passed in.
On https://github.com/react-bootstrap/react-overlays/blob/master/src/ModalManager.js#L93 should be something like hideSiblings(container, {root: modal.dialog});

@cameron-martin
Copy link

cameron-martin commented Dec 5, 2019

Actually, the code above is obsolete.

This is in the version used by the latest stable version of react-bootstrap. Would you consider releasing a patch for this on that basis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants