Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove affix support #287

Merged
merged 1 commit into from
Mar 14, 2019
Merged

feat: Remove affix support #287

merged 1 commit into from
Mar 14, 2019

Conversation

taion
Copy link
Member

@taion taion commented Mar 14, 2019

No description provided.

@taion taion requested a review from jquense March 14, 2019 18:59
@taion
Copy link
Member Author

taion commented Mar 14, 2019

I also removed getDocumentHeight and ownerWindow, which were only used by the affix components.

jquense
jquense approved these changes Mar 14, 2019
View reviewed changes
Copy link
Member

@jquense jquense left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farewell!

@taion taion merged commit cae4df8 into master Mar 14, 2019
@taion taion deleted the remove-affix branch March 14, 2019 19:29
@nicgordon nicgordon mentioned this pull request Jun 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @jquense