Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where did AutoAffix go? #953

Closed
nicgordon opened this issue Jun 3, 2021 · 3 comments
Closed

Where did AutoAffix go? #953

nicgordon opened this issue Jun 3, 2021 · 3 comments

Comments

@nicgordon
Copy link

Describe the bug

I am upgrading this package from an old version (0.9.3) and we are using the AutoAffix component. That does not seem to be exported from this package anymore but there is nothing in the changelog talking about its removal, nor can I seem to find the commit when it disappeared.

Is there a suggested migration path for those using AutoAffix?

To Reproduce

Steps to reproduce the behavior:

  1. Install v0.9.3
  2. Use the AutoAffix component via import { AutoAffix } from 'react-overlays';
  3. Upgrade to v5.0.1

Expected behavior

At least a note in the changelog about when it was removed and potentially a migration option.

@nicgordon
Copy link
Author

Okay after some digging I found this PR #287 but there is nothing even on the description as to why it was removed or what consumers ought to do?

@jquense
Copy link
Member

jquense commented Jun 3, 2021

i don't really remember the context it was like 3 years ago i think? There isn't a real need for this component anymore position: sticky is very well supported now, and for old browsers better to use a sticky polyfill

@jquense jquense closed this as completed Jun 3, 2021
@nicgordon
Copy link
Author

Thanks for the reply @jquense.

For any others that might stumble upon this here are some alternatives that I have found:

Or yes, write something custom using the position: sticky css property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants