Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn fixes #150

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Yarn fixes #150

wants to merge 3 commits into from

Conversation

Dzuelu
Copy link

@Dzuelu Dzuelu commented Dec 27, 2024

Fixed so yarn is able to install and run without using npm first. The tests didn't run on my os (linux mint 22) so I wasn't able to test that, but I was able to run dev/prod releases.

Contributing guidelines

Please do the following steps before submitting a PR, doing this will help progress your fix into the template.

  1. Have you ran npm run test? Yes, they fail for both npm and yarn tho....
  2. Have you ran npm run dev? Yes, works
  3. Have you ran npm run prod? Yes, works
  4. Have you ran npm run dist-[windows|mac|linux|all]? Yes, gives same chrome error as tests but starts successfully.

Example chrome error output on run dist-linux

➜  secure-electron-template git:(yarnFixes) npm run dist-linux

> [email protected] dist-linux
> npm run test && npm run prod-build && electron-builder --linux


> [email protected] test
> mocha



  Application launch
    1) "before each" hook for "shows an initial window"


  0 passing (2s)
  1 failing

  1) Application launch
       "before each" hook for "shows an initial window":
     Error: Failed to create session.
unknown error: Chrome failed to start: exited abnormally.
  (unknown error: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /home/kenny/git/tmp/secure-electron-template/node_modules/spectron/lib/launcher.js is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
      at startWebDriverSession (node_modules/webdriver/build/utils.js:72:15)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
      at async WebDriver.newSession (node_modules/webdriver/build/index.js:58:45)
      at async Object.remote (node_modules/webdriverio/build/index.js:73:22)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant