Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unmarshal the set value to a json value to avoid stringification of bools #14

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: Unmarshal the set value to a json value to avoid stringification of bools #14

merged 2 commits into from
Aug 2, 2024

Conversation

marcusramberg
Copy link
Contributor 

❯ ./helmfile-nix  -f ../aws-cicd/helm/arc/helmfile.nix render --state-values-set scale_sets_installed=false|grep installed
2024/08/01 19:28:40 Args: [./helmfile-nix render]
2024/08/01 19:28:40 file: dev env: ../aws-cicd/helm/arc/helmfile.nix
2024/08/01 19:28:40 Running nix --extra-experimental-features nix-command --extra-experimental-features flakes eval --json --impure --expr (import /var/folders/bn/5t6p0fy52kl3qg2dr2bqbm440000gp/T/eval.1421950222.nix).render "/Users/marcus/Source/reMarkable/aws-cicd/helm/arc" "dev" "/var/folders/bn/5t6p0fy52kl3qg2dr2bqbm440000gp/T/val.4234348001.json"
      installed: true
      installed: false
      installed: false
      installed: false

@marcusramberg marcusramberg requested a review from a team as a code owner August 1, 2024 17:29
@marcusramberg marcusramberg requested review from nikolaik, annaken, escarls and rjmoseley and removed request for a team August 1, 2024 17:29
@marcusramberg marcusramberg changed the title fix: Marshal the set value to a json value to avoid stringification of bools fix: Unmarshal the set value to a json value to avoid stringification of bools Aug 1, 2024
@marcusramberg marcusramberg force-pushed the marcus/fix_state_values branch 3 times, most recently from b2df9a8 to 60f979c Compare August 1, 2024 18:52
nikolaik
nikolaik approved these changes Aug 2, 2024
View reviewed changes
Copy link

@nikolaik nikolaik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcusramberg marcusramberg merged commit 5f6dbb1 into main Aug 2, 2024
2 checks passed
@marcusramberg marcusramberg deleted the marcus/fix_state_values branch August 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolaik nikolaik nikolaik approved these changes

@annaken annaken Awaiting requested review from annaken annaken is a code owner automatically assigned from reMarkable/cloud-services

@escarls escarls Awaiting requested review from escarls escarls is a code owner automatically assigned from reMarkable/cloud-services

@rjmoseley rjmoseley Awaiting requested review from rjmoseley rjmoseley is a code owner automatically assigned from reMarkable/cloud-services

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcusramberg @nikolaik