Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to evaluate expressions on constants #14

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Allow to evaluate expressions on constants #14

wants to merge 8 commits into from

Commits on Dec 20, 2019

  1. added a test which is failing

    Vasily Kabanov committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    24bf393 View commit details
    Browse the repository at this point in the history

  2. un-sealed and made public 2 classes allowing to override so that expr… 

    …essions on constants can be evaluated (in external code)
    Vasily Kabanov committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    ff77b11 View commit details
    Browse the repository at this point in the history

  3. consider parameter evauatable if it is supplied by evaluatable expres… 

    …sion
    Vasily Kabanov committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    eb10610 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. Disallow evaluation of expressions involving parameters by default, a… 

    …llow to override it in the filter. Unit tests pass.
    Vasily Kabanov committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    5986125 View commit details
    Browse the repository at this point in the history

  2. restored casting to IEnumerable in SubQuery_InNewExpression_RetainsTy… 

    …pe test and added complementary SubQuery_InNewExpression_RetainsTypeWithEvaluatableParameterButQueryableConstant
    Vasily Kabanov committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    66ddbaf View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2020

  1. fixed new test SubQuery_InNewExpression_ConvertsToConstantWithEvaluat… 

    …ableParameter compilation for .net 4.0 and below
    Vasily Kabanov committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    74f1e98 View commit details
    Browse the repository at this point in the history

  2. replaced simple null-checking with ArgumentUtility.CheckNotNull

    Vasily Kabanov committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    28eac83 View commit details
    Browse the repository at this point in the history

  3. Re-sealed EvaluatableTreeFindingExpressionVisitor and made PartialEva… 

    …luatingExpressionVisitor constructor private again as required by maintainer
    Vasily Kabanov committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    5d7ec7a View commit details
    Browse the repository at this point in the history