Make src an optional paramter

[brizandrew]

I'm using this to create a sandboxed iFrame that shouldn't have a src. I've tried to work within the constructor provided, but all the options are conflicting with my ability to inject content into it.

Things I've tried to get around the problem:

• Not passing a src makes the iframe have src="undefined"
• Passing it a blank src makes the iframe have src(unknown).
• Passing it a null src makes the iframe have src="null".

I think the best thing to do is simply not set the attribute if it's not provided to the constructor.

Happy to talk some more about my (admittedly a-typical) use case if you'd like.

[rdmurphy]

Interesting! No prob making this a thing, but what's the typical use case? I'm aware of srcdoc (which this also doesn't support yet), but are there other paths too?

[brizandrew]

We’re playing around with being able to run some code in an environment where it’s easy to tear it down (by deleting the iframe) and run it again by running eval from the iFrame’s window.

Not something we’d do in audience-facing content but it’s in the works for one of our new tools.

I got the whole thing working with a standard iframe I made using document.createElement but when I tried doing the same thing with an iFrame that has a src (even if it’s blank) the code stopped working so I realized that’s why this library wasn’t working for me either.

[rdmurphy]

Hello! 👋 I'm sure y'all long ago moved on from this but did wanna say I have a pretty significant reworking coming that will enable this (and make any attributes you'd like able to be passed).

[brizandrew]

Pretty sure I'm still using a custom version for this. So would be great to replace that with an official release. Looking forward to the update!

[rdmurphy]

This is now going to be possible in 1.0.0! It's still at @newswire/frames@beta, but will likely move to latest later today. 🎉