-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delia 65017 es1 1055 delia 65244 rdktv 31830 delia 65243 xumo 3 #5541
Merged
anand-ky
merged 12 commits into
rdkcentral:release/xumo_3
from
npoltorapavlo:DELIA-65017_ES1-1055_DELIA-65244_RDKTV-31830_DELIA-65243_xumo_3
Jul 24, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0cd3715
Merge pull request #5158 from rdkcentral/ES1-1055
anand-ky 8e99cc6
Merge pull request #5289 from rdkcentral/ES1-1055_DELIA-65233_main
anand-ky 7882379
Merge pull request #5263 from npoltorapavlo/DELIA-65244
anand-ky 608b320
Merge pull request #5364 from npoltorapavlo/DELIA-65244_main
anand-ky f745422
Merge pull request #5178 from rdkcentral/DELIA-65017
anand-ky b0aafd4
Merge pull request #5426 from npoltorapavlo/DELIA-65017_main
anand-ky d2b1087
Revert "RDKTV-31765: Set US endpoint - SecureStore"
npoltorapavlo df03195
Merge pull request #5444 from npoltorapavlo/fix_Thunder_masterbranch_…
anand-ky 42fedf0
Merge pull request #5462 from npoltorapavlo/fix_Thunder_masterbranch_…
anand-ky 9deadf6
Merge pull request #5503 from npoltorapavlo/DELIA-65243
apatel859 2c5ea6a
Merge pull request #5530 from npoltorapavlo/DELIA-65243_main
anand-ky 6e33470
RDKTV-31830 : split Cloud Store in a separate plugin
npoltorapavlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| name: L0-CloudStore | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
| pull_request: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: ${{github.repository}} | ||
|
|
||
| - name: Install valgrind, coverage, cmake | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y valgrind lcov cmake | ||
|
|
||
| - name: Build Thunder | ||
| working-directory: ${{github.workspace}} | ||
| run: sh +x ${GITHUB_REPOSITORY}/.github/workflows/BuildThunder.sh | ||
|
|
||
| - name: Build | ||
| working-directory: ${{github.workspace}} | ||
| run: | | ||
| cmake -S ${GITHUB_REPOSITORY}/CloudStore/l0test -B build/cloudstorel0test -DCMAKE_INSTALL_PREFIX="install" -DCMAKE_CXX_FLAGS="--coverage -Wall -Werror" | ||
| cmake --build build/cloudstorel0test --target install | ||
|
|
||
| - name: Run | ||
| working-directory: ${{github.workspace}} | ||
| run: PATH=${PWD}/install/bin:${PATH} LD_LIBRARY_PATH=${PWD}/install/lib:${LD_LIBRARY_PATH} valgrind --tool=memcheck --log-file=valgrind_log --leak-check=yes --show-reachable=yes --track-fds=yes --fair-sched=try cloudstorel0test | ||
|
|
||
| - name: Generate coverage | ||
| working-directory: ${{github.workspace}} | ||
| run: | | ||
| lcov -c -o coverage.info -d build/cloudstorel0test | ||
| genhtml -o coverage coverage.info | ||
|
|
||
| - name: Upload artifacts | ||
| if: ${{ !env.ACT }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: artifacts | ||
| path: | | ||
| coverage/ | ||
| valgrind_log | ||
| if-no-files-found: warn |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: L2-CloudStore-grpc | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
| pull_request: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: ${{github.repository}} | ||
|
|
||
| - name: Install cmake, protoc, grpc_cpp_plugin, grpc | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y cmake protobuf-compiler protobuf-compiler-grpc libgrpc++-dev | ||
|
|
||
| - name: Build | ||
| working-directory: ${{github.workspace}} | ||
| run: | | ||
| cmake -S ${GITHUB_REPOSITORY}/CloudStore/grpc/l2test -B build/grpcl2test -DCMAKE_INSTALL_PREFIX="install" -DCMAKE_CXX_FLAGS="-Wall -Werror" | ||
| cmake --build build/grpcl2test --target install | ||
|
|
||
| # Usage: | ||
| # Build with real token (here: "Bearer TOKEN")!!! | ||
| # PATH=${PWD}/install/bin:${PATH} LD_LIBRARY_PATH=${PWD}/install/lib:${LD_LIBRARY_PATH} valgrind --tool=memcheck --log-file=valgrind_log --leak-check=yes --show-reachable=yes --track-fds=yes --fair-sched=try grpcl2test |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: L2-CloudStore | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
| pull_request: | ||
| paths: | ||
| - CloudStore/** | ||
| - .github/workflows/*CloudStore*.yml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: ${{github.repository}} | ||
|
|
||
| - name: Install cmake, protoc, grpc_cpp_plugin, grpc | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y cmake protobuf-compiler protobuf-compiler-grpc libgrpc++-dev | ||
|
|
||
| - name: Build Thunder | ||
| working-directory: ${{github.workspace}} | ||
| run: sh +x ${GITHUB_REPOSITORY}/.github/workflows/BuildThunder.sh | ||
|
|
||
| - name: Build | ||
| working-directory: ${{github.workspace}} | ||
| run: | | ||
| cmake -S ${GITHUB_REPOSITORY}/CloudStore -B build/CloudStore -DCMAKE_INSTALL_PREFIX="install" -DCMAKE_CXX_FLAGS="-Wall -Werror" -DPLUGIN_CLOUDSTORE_MODE=Local -DPLUGIN_CLOUDSTORE_URI=ss.eu.prod.developer.comcast.com:443 | ||
| cmake --build build/CloudStore --target install | ||
|
|
||
| # Usage: | ||
| # PATH=${PWD}/install/bin:${PATH} LD_LIBRARY_PATH=${PWD}/install/lib:${LD_LIBRARY_PATH} valgrind --tool=memcheck --log-file=valgrind_log --leak-check=yes --show-reachable=yes --track-fds=yes --fair-sched=try Thunder -f -c ${PWD}/install/etc/Thunder/config.json | ||
| # (to stop press q & enter) | ||
| # curl -d '{"jsonrpc":"2.0","id":0,"method":"org.rdk.CloudStore.setValue","params":{"namespace":"test","key":"key1","value":"1","ttl":100}}' http://localhost:55555/jsonrpc |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| name: L2-PersistentStore | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - PersistentStore/** | ||
| - .github/workflows/*PersistentStore*.yml | ||
| pull_request: | ||
| paths: | ||
| - PersistentStore/** | ||
| - .github/workflows/*PersistentStore*.yml | ||
|
|
||
| jobs: | ||
| build: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| path: ${{github.repository}} | ||
|
|
||
| - name: Install cmake, sqlite | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install -y cmake libsqlite3-dev | ||
|
|
||
| - name: Build Thunder | ||
| working-directory: ${{github.workspace}} | ||
| run: sh +x ${GITHUB_REPOSITORY}/.github/workflows/BuildThunder.sh | ||
|
|
||
| - name: Build | ||
| working-directory: ${{github.workspace}} | ||
| run: | | ||
| cmake -S ${GITHUB_REPOSITORY}/PersistentStore -B build/PersistentStore -DCMAKE_INSTALL_PREFIX="install" -DCMAKE_CXX_FLAGS="-Wall -Werror" -DPLUGIN_PERSISTENTSTORE_PATH="/tmp/persistentstore/l2test/test" -DPLUGIN_PERSISTENTSTORE_MODE=Local | ||
| cmake --build build/PersistentStore --target install | ||
|
|
||
| # Usage: | ||
| # PATH=${PWD}/install/bin:${PATH} LD_LIBRARY_PATH=${PWD}/install/lib:${LD_LIBRARY_PATH} valgrind --tool=memcheck --log-file=valgrind_log --leak-check=yes --show-reachable=yes --track-fds=yes --fair-sched=try Thunder -f -c ${PWD}/install/etc/Thunder/config.json | ||
| # (to stop press q & enter) | ||
| # curl -d '{"jsonrpc":"2.0","id":0,"method":"org.rdk.PersistentStore.setValue","params":{"namespace":"test","key":"key1","value":"1","ttl":100}}' http://localhost:55555/jsonrpc |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this RDK Service will be documented in this file. | ||
|
|
||
| * Each RDK Service has a CHANGELOG file that contains all changes done so far. When version is updated, add a entry in the CHANGELOG.md at the top with user friendly information on what was changed with the new version. Please don't mention JIRA tickets in CHANGELOG. | ||
|
|
||
| * Please Add entry in the CHANGELOG for each version change and indicate the type of change with these labels: | ||
| * **Added** for new features. | ||
| * **Changed** for changes in existing functionality. | ||
| * **Deprecated** for soon-to-be removed features. | ||
| * **Removed** for now removed features. | ||
| * **Fixed** for any bug fixes. | ||
| * **Security** in case of vulnerabilities. | ||
|
|
||
| * Changes in CHANGELOG should be updated when commits are added to the main or release branches. There should be one CHANGELOG entry per JIRA Ticket. This is not enforced on sprint branches since there could be multiple changes for the same JIRA ticket during development. | ||
|
|
||
| * For more details, refer to [versioning](https://github.com/rdkcentral/rdkservices#versioning) section under Main README. | ||
|
|
||
| ## [1.0.0] - 2024-07-15 | ||
| ### Added | ||
| - Add CHANGELOG | ||
|
|
||
| ### Change | ||
| - Reset API version to 1.0.0 | ||
| - Change README to inform how to update changelog and API version |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove references to your fork.