Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/SYSTEST-9487 add live session logging #136

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

ksentak
Copy link
Contributor

@ksentak ksentak commented Aug 3, 2023

MF allows users to record "sessions" of communication to/from MF to a log file. This file is only updated when a session is stopped. I added functionality to output data to the file as soon as it's received by MF.

@ksentak ksentak marked this pull request as ready for review August 3, 2023 18:47
cli/src/usage.mjs Show resolved Hide resolved
server/src/sessionManagement.mjs Outdated Show resolved Hide resolved
cli/README.md Outdated Show resolved Hide resolved
michaelcfine
michaelcfine previously approved these changes Aug 8, 2023
Copy link
Contributor

@michaelcfine michaelcfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit surprised to see 'live' as an output choice (along with raw), but I guess I get it given the lack of outer array or object. Otherwise, I think very minor comments. 👍

cli/README.md Show resolved Hide resolved
cli/README.md Outdated Show resolved Hide resolved
server/src/sessionManagement.mjs Outdated Show resolved Hide resolved
Copy link
Contributor

@michaelcfine michaelcfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM!

@kschrief kschrief merged commit b0ec107 into rdkcentral:main Aug 11, 2023
@ksentak ksentak deleted the feature/SYSTEST-9487 branch August 11, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants