Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update lightning inspector root div offset - Fixes #426 #427

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

chiefcll
Copy link
Contributor

No description provided.

@chiefcll chiefcll changed the title Fixes #426 update lightning inspector root div offset - Fixes #426 Oct 26, 2022
@frank-weindel frank-weindel linked an issue Oct 26, 2022 that may be closed by this pull request
@michielvandergeest
Copy link
Contributor

Looks good to me.

I guess we should consider this a hotfix (i.e. to be released outside of the quarterly release schedule)?
If so, then it's okay to do the PR straight to master. We would just need to version bump and update the changelog as well.

@erikhaandrikman erikhaandrikman self-requested a review October 31, 2022 12:52
@erikhaandrikman erikhaandrikman merged commit 3d2d7e3 into rdkcentral:master Oct 31, 2022
g-zachar pushed a commit that referenced this pull request Mar 11, 2023
update lightning inspector root div offset - Fixes #426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning Inspector root element is not offset correctly
3 participants