Replace BinDeps.jl with Tar.jl #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeits
changed the title
|
This doesn't quite work yet. Blink.jl fails to build with the same missing 7z.exe error: I suspect this is probably fixed in Blink.jl v0.12.6: https://github.com/JuliaGizmos/Blink.jl/releases/tag/v0.12.6, but we can't use that. It looks like the restriction to WebSockets.jl v1.5 also restricts us to HTTP.jl < v1.0, which is incompatible with Blink.jl v0.12.6. So we have to resolve the WebSockets issue #237 first. |
rdeits
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was intended to help with #236 by avoiding requiring 7z.exe to unpack .tar files. It doesn't actually fix the Windows CI issue (see #240 (comment) ), but I think it's still a good idea. Tar.jl seems better-maintained than BinDeps.jl, and I'd rather not rely on the existence of 7z.exe anyway.