Constrain WebSockets.jl version to <1.6 #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrolho
force-pushed
the
hf/websockets-issue
branch
2 times, most recently
from
9821fce to
2e6f16b
Compare
ferrolho
force-pushed
the
hf/websockets-issue
branch
from
2e6f16b to
fddda1c
Compare
|
Nice, thanks for finding the root cause here. It's annoying to restrict the WebSockets version, but it's much better than just being broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraining WebSockets.jl to versions <1.6 fixes #234
but is also causing the Windows CI pipeline to fail.Edit 1: Actually, this is not the breaking change. Something else must have broken the pipeline, because after having run the pipeline for the previous master today, that one is failing too (when previously it was succeeding).
Edit 2: I have decided to temporarily disable the Windows runner from the CI and move the task for fixing it to #236.