Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some deprecated functions #143

Merged
merged 9 commits into from
Feb 12, 2020
Merged

Remove some deprecated functions #143

merged 9 commits into from
Feb 12, 2020

Conversation

rdeits
Copy link
Owner

@rdeits rdeits commented Feb 11, 2020

On top of #141

  • Removes the old (pre-Cassette)-style animation atframe method
  • Removes HyperCylinder, which has been a deprecated alias for Cylinder for a long time

@codecov-io
Copy link

Codecov Report

Merging #143 into master will increase coverage by 2.21%.
The diff coverage is 55.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   79.27%   81.48%   +2.21%     
==========================================
  Files          15       18       +3     
  Lines         468      470       +2     
==========================================
+ Hits          371      383      +12     
+ Misses         97       87      -10
Impacted Files Coverage Δ
src/geometry.jl 100% <ø> (ø) ⬆️
src/atframe.jl 87.09% <ø> (+1.8%) ⬆️
src/lowering.jl 98.48% <ø> (+8.2%) ⬆️
src/commands.jl 83.33% <ø> (+11.9%) ⬆️
src/assets.jl 0% <0%> (ø)
src/servers.jl 4% <0%> (-0.55%) ⬇️
src/integrations.jl 100% <100%> (ø)
src/MeshCat.jl 80% <100%> (+46.66%) ⬆️
src/render.jl 33.33% <33.33%> (ø)
src/visualizer.jl 91.42% <90.69%> (+15.37%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d0be1...e5ed4d2. Read the comment docs.

@rdeits rdeits merged commit 44e9240 into master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants