V0.45 Update CurrentHoldingsProvider to stop including DSN6 maps #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not as familiar with the code --- the CurrentHoldingsProvider code removal around line 210 -- is this because the other changes no-longer has it set? |
@epeisach Yes exactly. Instead of creating keys "2fofc Map" and "fofc Map", it just creates a single "Map Coefficients" key. Also FYI, this should be the only PR necessary—no changes are needed in the py-rcsb_db repository, because the workflow uses RepoHoldingsRemoteDataPrep.py (not RepoHoldingsDataPrep.py). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.