(HOLD) RO-2578: Schema updates for Data API 2.0 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe I should bundle this with the changes needed for RO-3099 as well... |
|
And this...RO-170 |
- Remove ordinal attribute from rcsb_polymer_instance_feature, rcsb_nonpolymer_instance_feature, rcsb_branched_instance_feature - Remove reference_scheme from all polymer_entity, polymer_entity_instance, branched_entity, and branched_entity_instance feature objects RO-3099: - Remove pdbx_reference_molecule_details from bird_chem_comp_core
piehld
changed the title
|
Thanks @brindakv, I've incorporated the changes required by the other tickets and updated the schema files. Are you able to have one more look? |
|
NOTE: Do not merge until ready for Data API 2.0 release (see comments on Jira here). When the time comes, will need to create a parallel PR to |
piehld
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RO-2595: Remove internal
_struct.pdbx_descriptorfrom schemaRO-170:
ordinalattribute fromrcsb_polymer_instance_feature,rcsb_nonpolymer_instance_feature,rcsb_branched_instance_featurereference_schemefrom allpolymer_entity,polymer_entity_instance,branched_entity, andbranched_entity_instancefeature objectsRO-3099:
pdbx_reference_molecule_detailsfrombird_chem_comp_core