Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course Delete Functionality #458

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Course Delete Functionality #458

wants to merge 11 commits into from

Conversation

vakrao
Copy link
Contributor

@vakrao vakrao commented Apr 27, 2017

Created new "Creator" attribute, added some field to seed data, added sweetalert dependency, delete functionality deletes all sections in a course before deleting course

@vakrao vakrao mentioned this pull request Apr 27, 2017
@vakrao
Copy link
Contributor Author

vakrao commented Apr 30, 2017

@kmcnellis should i delete all events related to the course when deletion is called as well? or should that be separate?

@kmcnellis
Copy link
Member

I think so, yes. Also submissions to those events

@kmcnellis
Copy link
Member

this should def be explained as a destructive operation. Maybe we can have some sort of archive like slack

… then deletes the course-need to change from permanent deletion to simply marking as deleted later
@vakrao vakrao requested review from jowlee and removed request for jowlee May 16, 2017 04:26
@kmcnellis
Copy link
Member

This ready now?

@vakrao
Copy link
Contributor Author

vakrao commented Jun 20, 2017

It permanently deletes-it does not hide

@kmcnellis
Copy link
Member

Lets get some tests for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants