Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag hyphens parsed as a time unit as an error #24

Closed
rcjsuen opened this issue Mar 8, 2018 · 0 comments
Closed

Flag hyphens parsed as a time unit as an error #24

rcjsuen opened this issue Mar 8, 2018 · 0 comments
Assignees
@rcjsuen
Labels
enhancement

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Mar 8, 2018 •
edited
Loading

It seems like we're ignoring the hyphen and not flagging the duration as an error.

FROM alpine
HEALTHCHECK --interval=5-5s CMD ls
$ docker build .
Sending build context to Docker daemon  1.695MB
Error response from daemon: Dockerfile parse error line 2: time: unknown unit - in duration 5-5s

$ docker run -v `pwd`/Dockerfile:/Dockerfile rcjsuen/dockerfile-utils lint /Dockerfile
$
@rcjsuen rcjsuen added the bug label Mar 8, 2018
@rcjsuen rcjsuen self-assigned this Mar 8, 2018
@rcjsuen rcjsuen closed this as completed in de8b17d Mar 8, 2018
@rcjsuen rcjsuen added enhancement and removed bug labels Mar 8, 2018
rcjsuen added a commit that referenced this issue Mar 8, 2018
@rcjsuen
Fix #24 Change CHANGELOG.md entry from Fixed to Added
add4d21 
As this is a new error and not an error that is a false positive, it
should be considered as an addition and not a fix.

Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen changed the title Unknown hyphen time unit not flagged as an error Flag hyphens parsed as a time unit as an error Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen