Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change build stages to not be case-sensitive #41

Closed
rcjsuen opened this issue Dec 1, 2018 · 1 comment
Closed

Change build stages to not be case-sensitive #41

rcjsuen opened this issue Dec 1, 2018 · 1 comment
Assignees
@rcjsuen
Labels
bug Something isn't working

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Dec 1, 2018

As build stages are actually case-insensitive, we need to tweak how they are supported in the following feature sets:

  • code completion
  • definition
  • highlight
  • rename

See moby/moby#36956.
@rcjsuen rcjsuen added the bug Something isn't working label Dec 1, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented Dec 22, 2018

Looks like code completion already takes this into account...

rcjsuen added a commit that referenced this issue Dec 22, 2018
@rcjsuen
WIP #41 Ignore casing of build stage definitions
fc5cb79 
Signed-off-by: Remy Suen <[email protected]>
rcjsuen added a commit that referenced this issue Dec 22, 2018
@rcjsuen
WIP #41 Highlight build stages ignoring casing
35378d3 
Signed-off-by: Remy Suen <[email protected]>
@rcjsuen rcjsuen self-assigned this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen