Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return plain text or Markdown in a hover depending on what the client wants #14

Closed
rcjsuen opened this issue Feb 28, 2018 · 1 comment
Closed

Return plain text or Markdown in a hover depending on what the client wants #14

rcjsuen opened this issue Feb 28, 2018 · 1 comment
Assignees
@rcjsuen
Labels
enhancement New feature or request

Comments

@rcjsuen
Copy link
Owner

rcjsuen commented Feb 28, 2018 •
edited
Loading

We should inspect the client's capabilities.textDocument.hover.contentFormat property to determine what kind of markup the client supports. If it supports Markdown then we should use Markdown for the returned hover information. If it doesn't then we should just send back plain text.
@rcjsuen rcjsuen added the enhancement New feature or request label Feb 28, 2018
@rcjsuen
Copy link
Owner Author

rcjsuen commented Mar 1, 2018

Opened rcjsuen/dockerfile-language-server#209 for the issue described by the original comment.

We need an API or flag to indicate whether the content of a hover should be returned in plain text or Markdown.

@rcjsuen rcjsuen changed the title Send Markdown or plain text to the client for hover requests depending on what kind of markup it supports Return plain text or Markdown in a hover depending on what the client wants Mar 1, 2018
@rcjsuen rcjsuen closed this as completed in 553117f Mar 7, 2018
@rcjsuen rcjsuen self-assigned this Apr 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcjsuen rcjsuen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rcjsuen