Skip to content

Commit

Permalink
Fix #103 Add support for --link in COPY instructions
Browse files Browse the repository at this point in the history
Signed-off-by: Remy Suen <[email protected]>
  • Loading branch information
rcjsuen committed May 4, 2022
1 parent 8e8218d commit b908858
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 8 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
All notable changes to this project will be documented in this file.

## [Unreleased]
### Added
- add support for validating the `--link` flag in COPY instructions ([#103](https://github.com/rcjsuen/dockerfile-language-service/issues/103)

### Fixed
- semantic tokens will no longer have negative values if quoted string content is inside a variable ([#104](https://github.com/rcjsuen/dockerfile-language-service/issues/104))

Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"dependencies": {
"dockerfile-ast": "0.4.2",
"dockerfile-utils": "0.9.4",
"dockerfile-utils": "0.10.0",
"vscode-languageserver-types": "3.17.0-next.3"
},
"main": "./lib/main.js",
Expand Down
6 changes: 6 additions & 0 deletions test/dockerValidate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,10 @@ describe("Docker Validation Tests", () => {
assert.strictEqual(1, problems.length);
assertInstructionCasing(problems[0], DiagnosticSeverity.Error);
});

it("issue #103", () => {
const content = "FROM alpine\nCOPY --link . .";
const problems = service.validate(content, { instructionCasing: ValidationSeverity.ERROR });
assert.strictEqual(0, problems.length);
});
});

0 comments on commit b908858

Please sign in to comment.