Skip to content

Commit

Permalink
Fix #32 Warn if JSON written with single quotes
Browse files Browse the repository at this point in the history
JSON requires strings to be enclosed in double quotes. If an
instruction's argments look like JSON but is written with single
quotes, create a warning to indicate that they should be written with
double quotes instead. It is possible to change this rule to flag the
issue as an error or to have it ignored.

Signed-off-by: Remy Suen <[email protected]>
  • Loading branch information
rcjsuen committed Apr 8, 2018
1 parent a1a80ab commit 65e09ad
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ interface Capabilities {
}
```
- allow documentation in CompletionItems to be provided in Markdown ([#12](https://github.com/rcjsuen/dockerfile-language-service/issues/12))
- warn if instruction is written in JSON form incorrectly with single quotes ([rcjsuen/dockerfile-utils#28](https://github.com/rcjsuen/dockerfile-utils/issues/28))

## [0.0.2] - 2018-03-08
### Added
Expand Down
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"dependencies": {
"dockerfile-ast": "0.0.3",
"dockerfile-utils": "0.0.7",
"dockerfile-utils": "0.0.8",
"vscode-languageserver-types": "^3.6.0"
},
"main": "./lib/main.js",
Expand Down

0 comments on commit 65e09ad

Please sign in to comment.